Change in vdsm[master]: watchdog hook

peet at redhat.com peet at redhat.com
Wed Jan 9 11:33:06 UTC 2013


Peter V. Saveliev has posted comments on this change.

Change subject: watchdog hook
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File vdsm_hooks/watchdog/before_vm_start.py
Line 28:         watchdogaction = watchdog.split(':')[1]
Line 29: 
Line 30:         devices = domxml.getElementsByTagName('devices')[0]
Line 31:         watchdog_device = domxml.createElement('watchdog')
Line 32:         watchdog_device.setAttribute('model',watchdogmodel)
space after comma
Line 33:         watchdog_device.setAttribute('action',watchdogaction)
Line 34: 
Line 35:         devices.appendChild(watchdog_device)
Line 36: 


Line 29: 
Line 30:         devices = domxml.getElementsByTagName('devices')[0]
Line 31:         watchdog_device = domxml.createElement('watchdog')
Line 32:         watchdog_device.setAttribute('model',watchdogmodel)
Line 33:         watchdog_device.setAttribute('action',watchdogaction)
the same
Line 34: 
Line 35:         devices.appendChild(watchdog_device)
Line 36: 
Line 37:         hooking.write_domxml(domxml)


--
To view, visit http://gerrit.ovirt.org/10619
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1d21ff8e14013869d78532632e8485f0414793
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list