Change in vdsm[master]: WIP storage: Alert for using vdsm.conf nfs_mount_options

smizrahi at redhat.com smizrahi at redhat.com
Mon Jan 7 15:01:33 UTC 2013


Saggi Mizrahi has posted comments on this change.

Change subject: WIP storage: Alert for using vdsm.conf nfs_mount_options
......................................................................


Patch Set 2:

I thought you missed my point. I fully understand why and when the alerts are being use. I gave -2 because this involves a schema change and creates "A mechanism to send the alert". I don't want any mechanism put up to the supported API without fully thinking about how it affects the rest of VDSM.

If you want to add a mechanism you have to send and RFC like everyone else and show what the needs are and make sure it also addresses the needs of other subsystems.

Just as an example, the alert is attached to getCapabilities() instead of being tied to the object the alert relates to. This means that alerts that are not related to the entire host don't fit to this mechanism. Further more, I don't see why we need a special alert struct. Why can't we reuse the error struct?

--
To view, visit http://gerrit.ovirt.org/8979
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8520238e0b41eb95d035128681dc3b71a953e644
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list