Change in vdsm[master]: tests: add iscsi storage functional test

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Mon Jan 7 12:13:23 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: tests: add iscsi storage functional test
......................................................................


Patch Set 6: Looks good to me, but someone else must approve

(1 inline comment)

Pls see one suggestion provided in the comments. thanks

....................................................
File tests/functional/xmlrpcTests.py
Line 440:         rtslib.LUN(tpg, None, fio)
Line 441:         tpg.set_attribute('cache_dynamic_acls', '1')
Line 442:         tpg.set_attribute('generate_node_acls', '1')
Line 443:         tpg.set_attribute('authentication', '0')
Line 444:         tpg.set_attribute('demo_mode_write_protect', '0')
It would be good to provide some comments on why the set_attributes are needed, as well as the significance of each of the steps, done as part of the setup.  It will help understand the iscsi setup better.
Line 445:         tpg.enable = True
Line 446:         rtslib.NetworkPortal(tpg, self.address, 3260, mode='create')
Line 447: 
Line 448:     def _createBackend(self, backendDef, rollback):


--
To view, visit http://gerrit.ovirt.org/9842
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icaef5d6145b8f493b5eaab0b75564f88a4cb82ce
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list