Change in vdsm[master]: Adding isSpm parameter to getAllTasksList\Status

ybronhei at redhat.com ybronhei at redhat.com
Thu Feb 28 17:26:57 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding isSpm parameter to getAllTasksList\Status
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 310:         # If no pool exists, means not SPM
Line 311:         if len(pools['poollist']) == 0:
Line 312:             raise Exception('Not SPM')
Line 313:         for pool in pools['poollist']:
Line 314:             self.validateSPM(pool)
Check SPM is always on storage pool. Only if dc is connected to storage pool we can have host in SPM state. Currently we can have only 1 storage pool connected. This new function checks the connected storage pool uuid and checks if the current host is SPM for this pool, if there is no pool connected or the host is not the SPM for this pool, it throws exception
Line 315: 
Line 316:     def validateNotSPM(self, spUUID):
Line 317:         pool = self.getPool(spUUID)
Line 318:         if pool.spmRole != sp.SPM_FREE:


--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list