Change in vdsm[master]: Adding isSpm parameter to getAllTasksList\Status

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Thu Feb 28 15:20:08 UTC 2013


Shu Ming has posted comments on this change.

Change subject: Adding isSpm parameter to getAllTasksList\Status
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/API.py
Line 1363:     def getDevicesVisibility(self, guidList):
Line 1364:         return self._irs.getDevicesVisibility(guidList)
Line 1365: 
Line 1366:     def getAllTasksInfo(self, isSpm):
Line 1367:         return self._irs.getAllTasksInfo(isSpm)
I think the API api-shema file should be changed.
Line 1368: 
Line 1369:     def getAllTasksStatuses(self, isSpm):
Line 1370:         return self._irs.getAllTasksStatuses(isSpm)
Line 1371: 


Line 1366:     def getAllTasksInfo(self, isSpm):
Line 1367:         return self._irs.getAllTasksInfo(isSpm)
Line 1368: 
Line 1369:     def getAllTasksStatuses(self, isSpm):
Line 1370:         return self._irs.getAllTasksStatuses(isSpm)
The same as the above.
Line 1371: 
Line 1372:     def getAllTasks(self):
Line 1373:         return self._irs.getAllTasks()
Line 1374: 


....................................................
File vdsm/storage/hsm.py
Line 310:         # If no pool exists, means not SPM
Line 311:         if len(pools['poollist']) == 0:
Line 312:             raise Exception('Not SPM')
Line 313:         for pool in pools['poollist']:
Line 314:             self.validateSPM(pool)
I am thinking why should have two similar functions validateSPM() and validateSPMOnConnectedPool().  Also SPM is only meaningful to storage pool, so checking SPM is almost the same as checking SPM on a connected pool.
Line 315: 
Line 316:     def validateNotSPM(self, spUUID):
Line 317:         pool = self.getPool(spUUID)
Line 318:         if pool.spmRole != sp.SPM_FREE:


--
To view, visit http://gerrit.ovirt.org/12517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cbc11c924f0bd078749fea26d79b39c0dd48094
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list