Change in vdsm[master]: refactor libvirt event loop start

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Mon Feb 25 09:51:05 UTC 2013


Royce Lv has posted comments on this change.

Change subject: refactor libvirt event loop start
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/libvirtconnection.py
Line 167
Line 168
Line 169
Line 170
Line 171
As I can remember this 'setKeepAlive' line is added by me to resolve keepalive msg lost problem.

After consult with libvirt guys,without keepalive msg initiated by vdsm, libvirtd will still continuously send keepalive msg to vdsm, the connection will be alive as long as event loop's alive to respond to the msg. 

So I guess this can be safely retired.


--
To view, visit http://gerrit.ovirt.org/12306
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6795cc9b851a32b15df07b4c3f02a3303962ef33
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list