Change in vdsm[master]: refactor libvirt event loop start

vfeenstr at redhat.com vfeenstr at redhat.com
Mon Feb 25 09:01:56 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: refactor libvirt event loop start
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(1 inline comment)

Besides the removal of the comment it looks good to me, however I would like you to consider keeping this comment. Thanks.

....................................................
File vdsm/libvirtconnection.py
Line 167
Line 168
Line 169
Line 170
Line 171
Is there a reason for this comment being removed? This has been chosen to be there on purpose. Please do not simply remove it.


--
To view, visit http://gerrit.ovirt.org/12306
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6795cc9b851a32b15df07b4c3f02a3303962ef33
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list