Change in vdsm[master]: Change sudo wildcards to work with absolute paths

ybronhei at redhat.com ybronhei at redhat.com
Mon Feb 18 08:47:40 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Change sudo wildcards to work with absolute paths
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

Please follow the comments and update the patch. Thanks.

....................................................
File vdsm/sudoers.vdsm.in
Line 32:     @DD_PATH@ of=/sys/class/scsi_host/host*/scan, \
Line 33:     @DD_PATH@, \
Line 34:     @PERSIST_PATH@ *multipath.conf, \
Line 35:     @PERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 36:     @UNPERSIST_PATH@ *multipath.conf, \
If you modify the above to full path, you should also change here and in line 38 . and why not, in line 31 you do it anyways.
Line 37:     @UNPERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 38:     @CP_PATH@ *multipath.conf *, \
Line 39:     @CP_PATH@ * /var/log/vdsm/backup/* *, \
Line 40:     @MULTIPATH_PATH@ *, \


Line 36:     @UNPERSIST_PATH@ *multipath.conf, \
Line 37:     @UNPERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 38:     @CP_PATH@ *multipath.conf *, \
Line 39:     @CP_PATH@ * /var/log/vdsm/backup/* *, \
Line 40:     @MULTIPATH_PATH@ *, \
I also think it does the same, but as we wrote in this file all the possible options anyways, it doesn't matter if you'll leave it like that.
Line 41:     @BLOCKDEV_PATH@ --getsize64 *, \
Line 42:     @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \
Line 43:     @SERVICE_PATH@ vdsmd *, \
Line 44:     @REBOOT_PATH@ -f, \


--
To view, visit http://gerrit.ovirt.org/11687
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ac8f99bf54f28b1207fd0236f78c4d7d5169fdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list