Change in vdsm[master]: Change sudo wildcards to work with absolute paths

danken at redhat.com danken at redhat.com
Mon Feb 4 19:02:28 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Change sudo wildcards to work with absolute paths
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

how could it be that it has worked for everybody since the monstrosity of our sudoers.d file was conceived?

....................................................
File vdsm/sudoers.vdsm.in
Line 30:     @CAT_PATH@ /etc/iscsi/iscsid.conf, \
Line 31:     @CAT_PATH@ /etc/multipath.conf, \
Line 32:     @DD_PATH@ of=/sys/class/scsi_host/host*/scan, \
Line 33:     @DD_PATH@, \
Line 34:     @PERSIST_PATH@ *multipath.conf, \
it would be slightly less ugly and dangerous to spell out the exact path (here and elsewhere)
Line 35:     @PERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 36:     @UNPERSIST_PATH@ *multipath.conf, \
Line 37:     @UNPERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 38:     @CP_PATH@ *multipath.conf *, \


Line 36:     @UNPERSIST_PATH@ *multipath.conf, \
Line 37:     @UNPERSIST_PATH@ /var/log/vdsm/backup/*, \
Line 38:     @CP_PATH@ *multipath.conf *, \
Line 39:     @CP_PATH@ * /var/log/vdsm/backup/* *, \
Line 40:     @MULTIPATH_PATH@ *, \
is this really required? I think this line means exactly like the original
Line 41:     @BLOCKDEV_PATH@ --getsize64 *, \
Line 42:     @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \
Line 43:     @SERVICE_PATH@ vdsmd *, \
Line 44:     @REBOOT_PATH@ -f, \


--
To view, visit http://gerrit.ovirt.org/11687
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ac8f99bf54f28b1207fd0236f78c4d7d5169fdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list