Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...
danken at redhat.com
danken at redhat.com
Mon Dec 9 09:14:20 UTC 2013
Dan Kenigsberg has posted comments on this change.
Change subject: sanlock isconfigured raises an exception instead of returning result
......................................................................
Patch Set 1:
(1 comment)
....................................................
File lib/vdsm/tool/configurator.py
Line 137: raise RuntimeError("Failed to perform sanlock config.")
Line 138:
Line 139: def isconfigured(self, *args):
Line 140: """
Line 141: Return 0 if sanlock service requires a restart to reload the relevant
the doc says 0, the code says False. Confusing.
Line 142: supplementary groups.
Line 143: """
Line 144: _isconfigured = True
Line 145: proc_status_group_prefix = "Groups:\t"
--
To view, visit http://gerrit.ovirt.org/22184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list