Change in vdsm[master]: sanlock isconfigured raises an exception instead of returnin...

Alon Bar-Lev alonbl at redhat.com
Mon Dec 9 09:03:25 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: sanlock isconfigured raises an exception instead of returning result
......................................................................


Patch Set 1:

(1 comment)

....................................................
File lib/vdsm/tool/configurator.py
Line 159: 
Line 160:         except IOError as e:
Line 161:             if e.errno == os.errno.ENOENT:
Line 162:                 sys.stdout.write("sanlock service is not running")
Line 163:                 _isconfigured = False
it is configured if not running, right?
Line 164:             else:
Line 165:                 raise
Line 166: 
Line 167:         diskimage_gid = grp.getgrnam(DISKIMAGE_GROUP)[2]


-- 
To view, visit http://gerrit.ovirt.org/22184
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic174c702f7f5b491975829e227d8311aed26ec90
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list