Change in vdsm[master]: sp: Fix stopping domain monitors

danken at redhat.com danken at redhat.com
Thu Dec 5 23:44:22 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: sp: Fix stopping domain monitors
......................................................................


Patch Set 1:

(1 comment)

....................................................
Commit Message
Line 22: jobs, where there is no storage space left, while storage has plenty of space.
Line 23: The root cause of the error was anonymous thread running at unexpected times
Line 24: and stopping silently all domain monitors.  Adding some logging revealed that
Line 25: this thread was started from StoragePool.__del__ method. This thread was
Line 26: running 14 minutes after the original pool was disconnected, stopping domain
If a copyImage (which is an SPM operation) takes place while we are members of another pool, we have very serious things to worry about: that copyImage might be copying stuff into area used by the new SPM. We should have lost our SPMness before being added to a new pool - either by spmStop, by a vdsm suicide, or host fencing.
Line 27: monitors used by the current pool object. It seems that a task was holding a
Line 28: reference to the old pool, and when the task was finished, the old pool was
Line 29: finally destroyed.
Line 30: 


-- 
To view, visit http://gerrit.ovirt.org/22058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad80984ab44dd4a4e36b92330eb9320cf68f1580
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list