Change in vdsm[master]: sp: Fix stopping domain monitors

nsoffer at redhat.com nsoffer at redhat.com
Thu Dec 5 22:44:50 UTC 2013


Nir Soffer has posted comments on this change.

Change subject: sp: Fix stopping domain monitors
......................................................................


Patch Set 1:

(1 comment)

....................................................
Commit Message
Line 22: jobs, where there is no storage space left, while storage has plenty of space.
Line 23: The root cause of the error was anonymous thread running at unexpected times
Line 24: and stopping silently all domain monitors.  Adding some logging revealed that
Line 25: this thread was started from StoragePool.__del__ method. This thread was
Line 26: running 14 minutes after the original pool was disconnected, stopping domain
I'm pretty sure about my description - you can see that in log of this job:
http://jenkins-ci.eng.lab.tlv.redhat.com/job/rhevm_3.3_automation_coretools_two_hosts_restapi_vms_nfs_rest_factory_vdsm/46/ (see vdsm.log of cinteg04).

I suspect that the delay is caused by a copyImage task that keeps a reference to the pool. __del__ was called when this task was committed. We are still investigating this.
Line 27: monitors used by the current pool object. It seems that a task was holding a
Line 28: reference to the old pool, and when the task was finished, the old pool was
Line 29: finally destroyed.
Line 30: 


-- 
To view, visit http://gerrit.ovirt.org/22058
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad80984ab44dd4a4e36b92330eb9320cf68f1580
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list