Change in vdsm[master]: One shot prepare.

abaron at redhat.com abaron at redhat.com
Sun Aug 25 11:46:44 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: One shot prepare.
......................................................................


Patch Set 11:

(2 comments)

....................................................
File vdsm/storage/blockSD.py
Line 1027:     def getAllRemnants(self):
Line 1028:         vols, rems = self.getAllVolumesImages()
Line 1029:         return rems
Line 1030: 
Line 1031:     def linkRunImage(self, srcImgPath, imgUUID, volUUIDs):
s/linkRunImage/createImageLinks/
Line 1032:         """
Line 1033:         Creates a compatiblity layer for vdsm and qemu-img use.
Line 1034: 
Line 1035:         srcImgPath: Dir where the image volumes are.


Line 1029:         return rems
Line 1030: 
Line 1031:     def linkRunImage(self, srcImgPath, imgUUID, volUUIDs):
Line 1032:         """
Line 1033:         Creates a compatiblity layer for vdsm and qemu-img use.
s/.*/qcow chain is build by reading each qcow header and reading the path to the parent.  When creating the qcow layer, we pass a relative path which allows us to build a directory with links to all volumes in the chain anywhere we want.  This method creates a directory with the image uuid under /var/run/vdsm and creates sym links to all the volumes in the chain/
Line 1034: 
Line 1035:         srcImgPath: Dir where the image volumes are.
Line 1036:         """
Line 1037:         sdRunDir = os.path.join("/var/run/vdsm/storage", self.sdUUID)


-- 
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list