Change in vdsm[master]: One shot prepare.

abaron at redhat.com abaron at redhat.com
Sun Aug 25 11:23:18 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: One shot prepare.
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

selinux policy was released.
still need to address the remaining comments

....................................................
File vdsm/clientIF.py
Line 255:                 if res['status']['code']:
Line 256:                     raise vm.VolumeError(drive)
Line 257: 
Line 258:                 volPath = res['path']
Line 259:                 # res['imgVolumesInfo'] is in arbitary order
s/is in arbitary/order of imgVokumesInfo is not guaranteed/
Line 260:                 drive['volumeChain'] = res['imgVolumesInfo']
Line 261:                 drive['volumeInfo'] = res['info']
Line 262: 
Line 263:             # GUID drive format


-- 
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list