Change in vdsm[master]: Removing validate sd from spm verbs which calls ckvg and ref...

ykaplan at redhat.com ykaplan at redhat.com
Wed Aug 21 12:09:59 UTC 2013


Yeela Kaplan has posted comments on this change.

Change subject: Removing validate sd from spm verbs which calls ckvg and refreshes the domain metadata on the spm even though the spm already controls the changes (i.e. a lot of redundant time is wasted)
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 1857:         except se.StoragePoolUnknown:
Line 1858:             pool = sp.StoragePool(spUUID, self.taskMng)
Line 1859:         else:
Line 1860:             raise se.StoragePoolConnected(spUUID)
Line 1861: 
I will add a different patch for the name change.
Line 1862:         self.validateSdUUID(masterDom)
Line 1863: 
Line 1864:         if hostId is not None:
Line 1865:             misc.validateN(hostId, 'hostId')


-- 
To view, visit http://gerrit.ovirt.org/18275
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf597a9e53dad04ad7a01fc1d5ceb8a180a542f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list