Change in vdsm[master]: Removing validate sd from spm verbs which calls ckvg and ref...
abaron at redhat.com
abaron at redhat.com
Wed Aug 21 09:41:48 UTC 2013
Ayal Baron has posted comments on this change.
Change subject: Removing validate sd from spm verbs which calls ckvg and refreshes the domain metadata on the spm even though the spm already controls the changes (i.e. a lot of redundant time is wasted)
......................................................................
Patch Set 1:
(3 comments)
....................................................
File vdsm/storage/hsm.py
Line 683:
Line 684: This synchronous method is intended to be used only with COW volumes
Line 685: where the size can be updated simply changing the qcow2 header.
Line 686: """
Line 687: newSizeBytes = int(newSize)
no
Line 688: domain = self.validateSdUUID(sdUUID)
Line 689: volToExtend = domain.produceVolume(imgUUID, volUUID)
Line 690: volPath = volToExtend.getVolumePath()
Line 691: volFormat = volToExtend.getFormat()
Line 869: return
Line 870:
Line 871: pool = self.getPool(spUUID)
Line 872:
Line 873: try:
Right, but that is out of scope of this change and is risky.
Line 874: self.validateSdUUID(msdUUID)
Line 875: pool.refresh(msdUUID, masterVersion)
Line 876: except:
Line 877: self._disconnectPool(pool, pool.id, pool.scsiKey, False)
Line 1857: except se.StoragePoolUnknown:
Line 1858: pool = sp.StoragePool(spUUID, self.taskMng)
Line 1859: else:
Line 1860: raise se.StoragePoolConnected(spUUID)
Line 1861:
wrt updateVolumeSize, upload/download - should be removed from there as well.
I agree that the purpose should be clear from the name of the method so no problem with changing it, I normally would prefer doing that in a separate patch though as it is not directly related.
Line 1862: self.validateSdUUID(masterDom)
Line 1863:
Line 1864: if hostId is not None:
Line 1865: misc.validateN(hostId, 'hostId')
--
To view, visit http://gerrit.ovirt.org/18275
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf597a9e53dad04ad7a01fc1d5ceb8a180a542f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list