Change in vdsm[master]: modify mom functional test to use VdsProxy

gvallare at redhat.com gvallare at redhat.com
Tue Aug 20 09:31:01 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: modify mom functional test to use VdsProxy
......................................................................


Patch Set 1: Code-Review-1

Hi Mei looks good already only a minor comment.

What about creating a different VdsProxy object ? As you can see the current one contains methods specialized to test the networking part. I'm in favour of breaking it down in smaller objects which act as wrapper only to the relevant part of the API under test.

-- 
To view, visit http://gerrit.ovirt.org/18271
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I874d527e3919c1beff328183eb12f332f2399b95
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list