Change in vdsm[master]: vdsm: Reboot capability for VM

mbetak at redhat.com mbetak at redhat.com
Tue Aug 20 09:20:33 UTC 2013


Martin Betak has posted comments on this change.

Change subject: vdsm: Reboot capability for VM
......................................................................


Patch Set 17:

(1 comment)

....................................................
File vdsm/vm.py
Line 1619:         return m
Line 1620: 
Line 1621: 
Line 1622: class VmPowerDown(utils.CallbackChain):
Line 1623:     def __init__(self, vm, info):
Well I just wanted to separate field assignment from the logic that does the chain construction. Also the checkSuccess field being set via the base constructor seemed cleaner to me.
Line 1624:         super(VmPowerDown, self).__init__(checkSuccess=info['checkSuccess'])
Line 1625:         self.vm = vm
Line 1626:         self.info = info
Line 1627: 


-- 
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list