Change in vdsm[master]: vdsmd and supervdsmd: extract common init tasks and add init...

ybronhei at redhat.com ybronhei at redhat.com
Tue Aug 13 09:09:22 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter
......................................................................


Patch Set 13:

(3 comments)

....................................................
File vdsm/supervdsmServer.py
Line 413:         sys.exit(1)
Line 414: 
Line 415: 
Line 416: def _usage():
Line 417:     print "Usage:  supervdsmServer --sockfile=fullPath [--pidfile=fullPath]"
Currently its "supervdsmServer.py ...", I planned to remove the py suffix as in vdsm/vdsm
Line 418: 
Line 419: 
Line 420: def _parse_args():
Line 421:     argDict = {}


....................................................
File vdsm/vdsmd.init.in
Line 70:     fi
Line 71:     return 1
Line 72: }
Line 73: 
Line 74: reconfigure_libvirt() {
guess this should also move to vdsmd_init_commons..

and then you can remove VDSM_TOOL declaration from here
Line 75:     if [ "$1" = "force" ]; then
Line 76:         "$VDSM_TOOL" libvirt-configure --force
Line 77:     else
Line 78:         "$VDSM_TOOL" libvirt-configure


Line 192:     ;;
Line 193:     reconfigure)
Line 194:         # Jump over 'reconfigure'
Line 195:         shift 1
Line 196:         reconfigure_sanlock
you removed this function from here.. where is it btw?
Line 197:         reconfigure_libvirt "$@"
Line 198:     RETVAL=$?
Line 199:     ;;
Line 200:      *)


-- 
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list