Change in vdsm[master]: Don't down bonds and nics when adding vlan or resizing

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue Aug 13 08:42:23 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Don't down bonds and nics when adding vlan or resizing
......................................................................


Patch Set 7:

(1 comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 104:         # Needed to be before slave configuration for initscripts to add slave
Line 105:         # to bond.
Line 106:         is_ifcfg_controlled = netinfo.getIfaceCfg(bond.name)
Line 107:         are_options_applied = bond.are_options_applied()
Line 108:         if not is_ifcfg_controlled or not are_options_applied:
I believe there's some common logic could be separated from ifcfg's editBonding. you could move it to configNetwork or Bond class. At least the code above is not configurator related.
Line 109:             bridgeName = _netinfo.getBridgedNetworkForIface(bond.name)
Line 110:             if bridgeName:
Line 111:                 bond.master = Bridge(bridgeName, self, port=bond)
Line 112:             self.configApplier.addBonding(bond)


-- 
To view, visit http://gerrit.ovirt.org/17491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3075a2e65f06416c840c6a98689b77555b22e5d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list