Change in vdsm[master]: Adding utils package to outOfProcess and remoteFileHandler

ybronhei at redhat.com ybronhei at redhat.com
Tue Apr 30 11:29:21 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding utils package to outOfProcess and remoteFileHandler
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/remoteFileHandler.py
Line 29: import signal
Line 30: import sys
Line 31: import select
Line 32: from contextlib import contextmanager
Line 33: from vdsm import utils
The comment talks about child processes that don't need betterPopen and vdsm constants, and that vdsm package imports wont work if vdsm is not installed. to allow calling utils functions in child process we have to import it, as we do with fileUtils.

The comment doesn't say not to import vdsm stuff, but that if you use remoteFileHandler externally to vdsm, those imports won't work. Currently we don't do that.
Line 34: 
Line 35: if __name__ != "__main__":
Line 36:     # If you don't have the vdsm package installed this will fail. Luckily we
Line 37:     # don't need anything when the child spawns. Plus anything you don't have


--
To view, visit http://gerrit.ovirt.org/14325
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59d258b58a18aa187eb2b723aa018e22432d61d3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list