Change in vdsm[master]: Adding utils package to outOfProcess and remoteFileHandler

danken at redhat.com danken at redhat.com
Tue Apr 30 10:22:52 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Adding utils package to outOfProcess and remoteFileHandler
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-04-29 17:09:07 +0300
Line 4: Commit:     Yaniv Bronhaim <ybronhei at redhat.com>
Line 5: CommitDate: 2013-04-29 18:20:53 +0300
Line 6: 
Line 7: Adding utils package to outOfProcess and remoteFileHandler
I'd appreciate more information about this serious bug and its fix.
Line 8: 
Line 9: Change-Id: I59d258b58a18aa187eb2b723aa018e22432d61d3


....................................................
File vdsm/storage/remoteFileHandler.py
Line 29: import signal
Line 30: import sys
Line 31: import select
Line 32: from contextlib import contextmanager
Line 33: from vdsm import utils
I'm a bit confused with this addition, and the long comments below about not importing stuff from vdsm!
Line 34: 
Line 35: if __name__ != "__main__":
Line 36:     # If you don't have the vdsm package installed this will fail. Luckily we
Line 37:     # don't need anything when the child spawns. Plus anything you don't have


--
To view, visit http://gerrit.ovirt.org/14325
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59d258b58a18aa187eb2b723aa018e22432d61d3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list