Change in vdsm[master]: storage.misc: Move execCmd and its dependencies to vdsm.util...

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Fri Apr 26 09:02:50 UTC 2013


Zhou Zheng Sheng has posted comments on this change.

Change subject: storage.misc: Move execCmd and its dependencies to vdsm.utils
......................................................................


Patch Set 1:

Thanks Dan. I submit a patch to fix logskip and add you to the reviewers. When I read the code, I find there is no code related to changing the logger's name that appeared in the final log message, so I does not fix logger's name. I fix how logskip changes the file name, line number and the function name.

--
To view, visit http://gerrit.ovirt.org/14221
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8fb42035b24bc915aaa700ab128580bdb609d9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list