Change in vdsm[master]: storage.misc: Move execCmd and its dependencies to vdsm.util...

danken at redhat.com danken at redhat.com
Thu Apr 25 13:08:42 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: storage.misc: Move execCmd and its dependencies to vdsm.utils
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Zhou, I am so sorry that you are dragged into this, but logskip is a hornet nest. And it's not currently working. With your patch, I get

 MainThread::DEBUG::2013-04-25 15:39:47,000::misc::77::Storage.Misc.excCmd::(<lambda>) '/usr/bin/sudo -n /usr/bin/python /usr/share/vdsm/super
vdsmServer.py 4e04b806-5a00-438f-bd2c-a1afe9d04811 11518 /var/run/vdsm/svdsm.pid /var/run/vdsm/svdsm.time /var/run/vdsm/svdsm.sock 36' (cwd N
one)

while the whole intention of logskip was to have

 ... supervdsm::132::SuperVdsm::_start ...

as the interesting module, line, logger, and method.

Now I know that logskip is ALREADY broken in master. I just feel that this change makes it even more complex to fix.

Could you spend some more time deciphering this issue? If not, I suggest that we keep using the ad-hoc implementation of execCmd, and postpone this move to alter patch series.

--
To view, visit http://gerrit.ovirt.org/14221
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8fb42035b24bc915aaa700ab128580bdb609d9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list