Change in vdsm[master]: Update device hooks: Added before and after update device ho...

danken at redhat.com danken at redhat.com
Wed Apr 24 12:46:31 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Update device hooks: Added before and after update device hooks.
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

This patch looks much simpler!

....................................................
File vdsm/libvirtvm.py
Line 1645:                 network = DUMMY_BRIDGE
Line 1646:                 linkValue = 'down'
Line 1647: 
Line 1648:             netsToMirror = params.get('portMirroring',
Line 1649:                                       netConf.get('portMirroring', []))
Unrelated removal, I presume.
Line 1650:             with self.setLinkAndNetwork(netDev, netConf, linkValue, network):
Line 1651:                 with self.updatePortMirroring(netConf, netsToMirror):
Line 1652:                     return {'status': doneCode, 'vmList': self.status()}
Line 1653:         except (LookupError,


--
To view, visit http://gerrit.ovirt.org/13972
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fe7f5e6d8291cc227a323b324c977bcd5bc8295
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list