Change in vdsm[master]: Update device hooks: Added before and after update device ho...

gvallare at redhat.com gvallare at redhat.com
Wed Apr 24 09:39:59 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: Update device hooks: Added before and after update device hooks.
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 1737:         if params.get('deviceType') == vm.NIC_DEVICES:
Line 1738:             update = self._updateInterfaceDevice(params)
Line 1739:             new_nic_xml = update['new_nic_xml']
Line 1740:             del update['new_nic_xml']
Line 1741:             self.log.debug("Nic has been updated:\n %s" % new_nic_xml)
I've verified the log, a conf dict is logged after an updateDevice operation which doesn't contain information about hook script changes. I think having this logging stmt may be useful.
Line 1742:             hooks.after_update_device(new_nic_xml, self.conf)
Line 1743:         else:
Line 1744:             update = errCode['noimpl']
Line 1745: 


--
To view, visit http://gerrit.ovirt.org/13972
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fe7f5e6d8291cc227a323b324c977bcd5bc8295
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list