Change in vdsm[master]: guestIF: Additional object strings filtering

danken at redhat.com danken at redhat.com
Tue Apr 23 12:27:09 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: guestIF: Additional object strings filtering
......................................................................


guestIF: Additional object strings filtering

Filtering the plain UTF-8 data is not enough. The filter has
to be applied also on the object parsed from json to be really
effective.

Example why this is required:

o = json.loads('{ "x": "\\u0000" }')

Now the 'o' python object looks like this:
{ "x": "\x00" }

Therefore we need to filter even the parsed object

Change-Id: Id64438812a19b25b67b8e50c5c56b0d776c4463e
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
---
M tests/guestIFTests.py
M vdsm/guestIF.py
2 files changed, 40 insertions(+), 0 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Vinzenz Feenstra: Verified
  Dan Kenigsberg: Looks good to me, approved
  Michal Skrivanek: Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/14126
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id64438812a19b25b67b8e50c5c56b0d776c4463e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list