Change in vdsm[master]: guestIF: Additional object strings filtering

danken at redhat.com danken at redhat.com
Tue Apr 23 12:27:07 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: guestIF: Additional object strings filtering
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/guestIF.py
Line 349: 
Line 350:         return result
Line 351: 
Line 352:     def _parseLine(self, line):
Line 353:         line = _filterXmlChars(line)
Vinzenz refers me to our unittest of http://gerrit.ovirt.org/3379 where we guard against this kind of output.

I suppose that we should have better dealt with chaning xmlrpclib.escape ?
Line 354:         args = json.loads(line.decode('utf8'))
Line 355:         args = _filterObject(args)
Line 356:         name = args['__name__']
Line 357:         del args['__name__']


--
To view, visit http://gerrit.ovirt.org/14126
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id64438812a19b25b67b8e50c5c56b0d776c4463e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list