Change in vdsm[master]: Raise specific exception when local path not exist

fsimonce at redhat.com fsimonce at redhat.com
Wed Apr 10 10:23:49 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: Raise specific exception when local path not exist
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/storageServer.py
Line 462:         return os.path.join(self.localPathBase,
Line 463:                             self._path.replace("_", "__").replace("/", "_"))
Line 464: 
Line 465:     def checkTarget(self):
Line 466:         if not os.path.exists(self._path) or not os.path.isdir(self._path):
If there's any code that relies on validateDirAccess being successful when the path is missing (I doubt that there is) it should be changed asap.
Line 467:             raise se.StorageServerLocalNotDirError(self._path)
Line 468:         fileSD.validateDirAccess(self._path)
Line 469:         return True
Line 470: 


--
To view, visit http://gerrit.ovirt.org/13724
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9310e3895e30fa5b2ae9a092aa4c1fef508c8e96
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list