Change in vdsm[master]: NetReload: ConfigWriter, ifup/down to configurator

danken at redhat.com danken at redhat.com
Mon Apr 8 15:14:35 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: NetReload: ConfigWriter, ifup/down to configurator
......................................................................


Patch Set 9: I would prefer that you didn't submit this

(1 inline comment)

Moving the code to a new module is a valid first step. Underminor comment within.

(and if possible, have the module better named)

....................................................
File vdsm/ifcfgConfigurator.py
Line 1: # Copyright 2011-2012 Red Hat, Inc.
it's 2013 by now.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by
Line 5: # the Free Software Foundation; either version 2 of the License, or


--
To view, visit http://gerrit.ovirt.org/13182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f28fa717eb501f61ed922cf2571181ff3b42532
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list