Change in vdsm[master]: vm: catch getVolumeSize failures in _normalizeVdsmImg

abaron at redhat.com abaron at redhat.com
Sun Apr 7 07:49:50 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: vm: catch getVolumeSize failures in _normalizeVdsmImg
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/vm.py
Line 411:                 raise RuntimeError("Unable to get size for volume: " +
Line 412:                                    drv['volumeID'])
Line 413: 
Line 414:             drv['truesize'] = res['truesize']
Line 415:             drv['apparentsize'] = res['apparentsize']
Dan, assuming you could have truesize without apparentsize, that would cause a partial update of the drv.
I agree that it would be clearer, I wonder if we shouldn't invalidate the data we currently have in this state?
Line 416:         else:
Line 417:             drv['truesize'] = 0
Line 418:             drv['apparentsize'] = 0
Line 419: 


--
To view, visit http://gerrit.ovirt.org/13529
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e170a85100e57d7e644614a21038d869777b82
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list