Change in vdsm[master]: Make getAllVolumes() not fail on broken images.
abaron at redhat.com
abaron at redhat.com
Tue Apr 2 21:35:27 UTC 2013
Ayal Baron has posted comments on this change.
Change subject: Make getAllVolumes() not fail on broken images.
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 1006: self.__markForDelVols(sdUUID, imgUUID, toZero, sd.ZEROED_IMAGE_PREFIX)
Line 1007: zeroImgVolumes(sdUUID, imgUUID, toZero)
Line 1008: self.rmDCImgDir(imgUUID, volsImgs)
Line 1009:
Line 1010: def getAllVolumesImages(self):
comments still ignored
Line 1011: """
Line 1012: Return all the images that depend on a volume.
Line 1013:
Line 1014: Return dicts:
Line 1027: # Deleted images are not dependencies of valid volumes.
Line 1028: images = [img for img in ip.imgs
Line 1029: if not img.starstwith(sd.REMOVED_IMAGE_PREFIX)]
Line 1030: vols[volName] = sd.ImgsPar(tuple(images, ip.parent))
Line 1031: return vols, remnants
same
Line 1032:
Line 1033: def getAllVolumes(self):
Line 1034: vols, rems = self.getAllVolumesImages()
Line 1035: return vols
--
To view, visit http://gerrit.ovirt.org/12546
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8514236a5d4793f66709e9daf546fb46047414f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov at gmail.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Gadi Ickowicz <gickowic at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list