Change in vdsm[master]: [wip] volume: make volume._share idempotent

fsimonce at redhat.com fsimonce at redhat.com
Sun Sep 30 09:59:11 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: [wip] volume: make volume._share idempotent
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/fileVolume.py
Line 237:             ('metadata', self._getMetaVolumePath(),
Line 238:                          self._getMetaVolumePath(dstVolumePath), True),
Line 239:             ('lease', self._getLeaseVolumePath(),
Line 240:                       self._getLeaseVolumePath(dstVolumePath),
Line 241:                       sdCache.produce(self.sdUUID).hasVolumeLeases()),
In fact we always *try* to do it. But "itemRequired" it means that is *mandatory* and when you're sharing a template that is V1/V2 (probably no lease file if it was generated in 3.0) the share would fail. We could try to generate the template lease file here but I'm worried that we would be tangling different things together.
Line 242:         ]
Line 243: 
Line 244:         for itemName, srcPath, dstPath, itemRequired in itemsList:
Line 245:             self.log.debug("Sharing %s %s to %s (required: %s)", itemName,


--
To view, visit http://gerrit.ovirt.org/8270
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I237e4a8f094ba04dcd4ef7bff418e03f81162d8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list