Change in vdsm[master]: [wip] volume: make volume._share idempotent

abaron at redhat.com abaron at redhat.com
Sun Sep 30 07:24:21 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: [wip] volume: make volume._share idempotent
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/fileVolume.py
Line 237:             ('metadata', self._getMetaVolumePath(),
Line 238:                          self._getMetaVolumePath(dstVolumePath), True),
Line 239:             ('lease', self._getLeaseVolumePath(),
Line 240:                       self._getLeaseVolumePath(dstVolumePath),
Line 241:                       sdCache.produce(self.sdUUID).hasVolumeLeases()),
so why not always do this?
Line 242:         ]
Line 243: 
Line 244:         for itemName, srcPath, dstPath, itemRequired in itemsList:
Line 245:             self.log.debug("Sharing %s %s to %s (required: %s)", itemName,


--
To view, visit http://gerrit.ovirt.org/8270
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I237e4a8f094ba04dcd4ef7bff418e03f81162d8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list