Change in vdsm[master]: supervdsmServer is down after failed operation (#851832)

ybronhei at redhat.com ybronhei at redhat.com
Mon Sep 10 11:11:19 UTC 2012


Yaniv Bronhaim has uploaded a new change for review.

Change subject: supervdsmServer is down after failed operation (#851832)
......................................................................

supervdsmServer is down after failed operation (#851832)

https://bugzilla.redhat.com/show_bug.cgi?id=851832

After running operation that throws exception that we don't catch in
supervdsmServer, we catch it in ProxyCaller::__call__ method.
In this except code we reset supervdsmServer and call the same method
again.
If the exception is thrown again, we leave supervdsmServer down And this
is how supervdsmServer remains.
This patch omit the recall and leave the reset to keep on normal flow.

Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/supervdsm.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/01/7901/1

diff --git a/vdsm/supervdsm.py b/vdsm/supervdsm.py
index 79e8d81..75e93e2 100644
--- a/vdsm/supervdsm.py
+++ b/vdsm/supervdsm.py
@@ -67,7 +67,6 @@
             return callMethod()
         except (IOError, socket.error, AuthenticationError):
             self._supervdsmProxy._restartSupervdsm()
-            return callMethod()
 
 
 class SuperVdsmProxy(object):


--
To view, visit http://gerrit.ovirt.org/7901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list