Change in vdsm[master]: BZ#841555 A migration failure with an "AttributeError" excep...

danken at redhat.com danken at redhat.com
Mon Sep 10 10:33:45 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#841555 A migration failure with an "AttributeError" exception.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 2440:                 # when migration completes, see qemuMigrationFinish function).
Line 2441:                 # In this case self._dom is None because the function
Line 2442:                 # _waitForIncomingMigrationFinish didn't update it yet.
Line 2443:                 if self._dom:
Line 2444:                     hooks.after_vm_pause(self._dom.XMLDesc(0), self.conf)
this has a short test-and-later-set race condition. A safer approach would be

try:
  domxml = self._dom.XMLDesc(0)
except AttributeError:
  pass
else:
  hooks.after_vm_pause(domxml, self.conf)
Line 2445:         elif event == libvirt.VIR_DOMAIN_EVENT_RESUMED:
Line 2446:             self._guestCpuRunning = True
Line 2447:             if detail == libvirt.VIR_DOMAIN_EVENT_RESUMED_UNPAUSED:
Line 2448:                 hooks.after_vm_cont(self._dom.XMLDesc(0), self.conf)


--
To view, visit http://gerrit.ovirt.org/6901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b7ed13c6dc8d1d590449118cf167290f4630070
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list