Change in vdsm[master]: Make sure teardown() is called in case of errors

abaron at redhat.com abaron at redhat.com
Sun Oct 21 08:32:10 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Make sure teardown() is called in case of errors
......................................................................


Patch Set 1: Looks good to me, approved

This is not another 'prepare thing' it just makes prepare useable with 'with'.  I'm not familiar with a way of mandating usage of 'with' (not to mention that this is python and you can always bypass any mechanism).

--
To view, visit http://gerrit.ovirt.org/8667
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cefbcd72434aa4d766b50b3d05aa70ba8cd910c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dafna Ron <dron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list