Change in vdsm[master]: Make sure teardown() is called in case of errors

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Oct 21 07:59:40 UTC 2012


Eduardo has posted comments on this change.

Change subject: Make sure teardown() is called in case of errors
......................................................................


Patch Set 1: I would prefer that you didn't submit this

No need for another prepare thing!

If "... should be use unless there is absolutely no other choice!" should replace the actual prepare().

Which cases have "The Choice"?

--
To view, visit http://gerrit.ovirt.org/8667
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7cefbcd72434aa4d766b50b3d05aa70ba8cd910c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dafna Ron <dron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list