Change in vdsm[master]: libvirtvm: Cast text to string when creating text node

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Thu Oct 11 02:26:00 UTC 2012


Shu Ming has posted comments on this change.

Change subject: libvirtvm: Cast text to string when creating text node
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File tests/utilsTests.py
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
I think we can add IBM copyright here along with Red Hat's.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


....................................................
File vdsm/utils.py
Line 606:         return val
Line 607:     else:
Line 608:         raise ValueError("Refusing to convert type '%s' to unicode" % \
Line 609:                            varType)
Line 610: 
In the utils test case, "UnicodeDecodeError" exception is expected. It seems that convertToUnicode() doesn't raise up the exception from unicode().
Line 611: def execCmd(*args, **kwargs):
Line 612:     # import only after config as been initialized
Line 613:     from storage.misc import execCmd
Line 614:     return execCmd(*args, **kwargs)


--
To view, visit http://gerrit.ovirt.org/7832
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id22db83062eaf85645c2d61c83f3f20943918413
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel P. Berrange <berrange at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list