Change in vdsm[master]: image: avoid prezeroing optimization in some cases

vvolansk at redhat.com vvolansk at redhat.com
Wed Oct 10 20:02:51 UTC 2012


Vered Volansky has posted comments on this change.

Change subject: image: avoid prezeroing optimization in some cases
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 536:                     volParams = srcVol.getVolumeParams(bs=1)
Line 537: 
Line 538:                     # To avoid 'prezeroing' preallocated volume on NFS domain,
Line 539:                     # we create the target volume with minimal size and after
Line 540:                     # that w'll change its metadata back to the original size.
s/w'll/we'll/
Line 541:                     if (volParams['volFormat'] == volume.COW_FORMAT
Line 542:                             or volParams['prealloc'] == volume.SPARSE_VOL):
Line 543:                         volTmpSize = volParams['size']
Line 544:                     else:


--
To view, visit http://gerrit.ovirt.org/7935
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8f348af355b0f17ab66dd9d5ef57c905051c17
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>


More information about the vdsm-patches mailing list