Change in vdsm[master]: pep8 fixes

danken at redhat.com danken at redhat.com
Tue Nov 20 21:08:04 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: pep8 fixes
......................................................................


Patch Set 1: (1 inline comment)

Well, it would be best if you help Zhou fix the Fedora bug in pep8. But maybe rebuilding of http://kojipkgs.fedoraproject.org//packages/python-pep8/1.3.3/3.fc18/src/python-pep8-1.3.3-3.fc18.src.rpm would be sufficient to you.

....................................................
File vdsm/storage/misc.py
Line 735:                     firstException = e
Line 736: 
Line 737:         # re-raise the earliest exception
Line 738:         if firstException is not None:
Line 739:             raise firstException
oh no. reraising is the proper way, so that the traceback is continued to the calling functions. Catching and logging should be done only on the topmost level.
Line 740: 
Line 741:     def defer(self, func, *args, **kwargs):
Line 742:         self._finally.append((func, args, kwargs))
Line 743: 


--
To view, visit http://gerrit.ovirt.org/9366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbbba925fa0c9be78b0eb5eb3d07066dc3b3c5ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list