Change in vdsm[master]: pep8 fixes

lhornyak at redhat.com lhornyak at redhat.com
Tue Nov 20 20:45:17 UTC 2012


Laszlo Hornyak has posted comments on this change.

Change subject: pep8 fixes
......................................................................


Patch Set 1: (1 inline comment)

So I have to build and install pep8 from source?

....................................................
File vdsm/storage/misc.py
Line 735:                     firstException = e
Line 736: 
Line 737:         # re-raise the earliest exception
Line 738:         if firstException is not None:
Line 739:             raise firstException
Agreed. Wouldn't it be better to log all the exceptions rather than just trying to rethrow the first with its original stack trace?
Line 740: 
Line 741:     def defer(self, func, *args, **kwargs):
Line 742:         self._finally.append((func, args, kwargs))
Line 743: 


--
To view, visit http://gerrit.ovirt.org/9366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbbba925fa0c9be78b0eb5eb3d07066dc3b3c5ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list