Change in vdsm[master]: Adding support for force extend block domains

danken at redhat.com danken at redhat.com
Fri Nov 16 14:17:04 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Adding support for force extend block domains
......................................................................


Patch Set 7: I would prefer that you didn't submit this

I agree with Shu Ming: we have an "options" bag, we could have put "force" there, without breaking the API.

I never understood why you (Ayal) refrain of using "options", but still keep it in the API.

But that's an old argument, let's let pragmatism win this time.

--
To view, visit http://gerrit.ovirt.org/9192
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33ad4ee65d7303705d2cc8370502553125000ca0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list