Change in vdsm[master]: Adding support for force extend block domains

abaron at redhat.com abaron at redhat.com
Thu Nov 15 19:24:33 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: Adding support for force extend block domains
......................................................................


Patch Set 7: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/BindingXMLRPC.py
Line 408:     def domainDetachForced(self, sdUUID, spUUID, options=None):
Line 409:         domain = API.StorageDomain(sdUUID, spUUID)
Line 410:         return domain.detach(None, None, force=True)
Line 411: 
Line 412:     def domainExtend(self, sdUUID, spUUID, devlist, force=False, options=None):
'options' is defined in the API but not used in the command so it wouldn't make any difference.
Line 413:         domain = API.StorageDomain(sdUUID, spUUID)
Line 414:         return domain.extend(devlist, force)
Line 415: 
Line 416:     def domainFormat(self, sdUUID,


--
To view, visit http://gerrit.ovirt.org/9192
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33ad4ee65d7303705d2cc8370502553125000ca0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list