Change in vdsm[master]: Implement SSL session cache

Alon Bar-Lev alonbl at redhat.com
Tue Nov 13 18:02:51 UTC 2012


Alon Bar-Lev has posted comments on this change.

Change subject: Implement SSL session cache
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/SecureXMLRPCServer.py
Line 101:         # SSL connection:
Line 102:         return getattr(self.connection, name)
Line 103: 
Line 104: 
Line 105: class SSLClientSocket(object):
First, see the methods above are the same...

So yo do not need gettimeout, __getattr__ twice... server socket adds the constructor and accept... it actually extends socket.

Next, this is exactly what passive or accepted socket.

A client socket is the socket a CLIENT use to access a SERVER, probably by using a connect. a CLIENT usually initiate the connection.

These are the terms I am familiar with, not that it is that important.

So I think the SSLServerSocket should be (after rename SSLClientSocket to SSLSocket):

 class SSLServerSocket(SSLScoket):
     def __init__(self, raw, certfile=None, keyfile=None, ca_certs=None, session_id="vdsm"):
          <snip>
 
     def accept(self):
        client, address = self.connection.accept()
        client = SSLSocket(client)
        return client, address
Line 106:     """SSL decorator for client sockets.
Line 107: 
Line 108:     This class wraps a client socket returned by the accept method of a
Line 109:     server socket providing the SSL socket methods that are missing in


--
To view, visit http://gerrit.ovirt.org/8123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic75adee4070b415b8855af1f2ea289825496fbc1
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list