Change in vdsm[master]: Implement SSL session cache

juan.hernandez at redhat.com juan.hernandez at redhat.com
Tue Nov 13 17:54:02 UTC 2012


Juan Hernandez has posted comments on this change.

Change subject: Implement SSL session cache
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vdsm/SecureXMLRPCServer.py
Line 101:         # SSL connection:
Line 102:         return getattr(self.connection, name)
Line 103: 
Line 104: 
Line 105: class SSLClientSocket(object):
Lets look at it from this point of view:

  SSLServerSocket = a socket that the server uses to accept clients
  SSLClientSocket = a socket that the server uses to talk to the client

The "server socket" shouldn't extend the "client socket" because a "server socket" is not "a socket that the server uses to talk to the client", so using inheritance for that is conceptually wrong, in my opinion.
Line 106:     """SSL decorator for client sockets.
Line 107: 
Line 108:     This class wraps a client socket returned by the accept method of a
Line 109:     server socket providing the SSL socket methods that are missing in


--
To view, visit http://gerrit.ovirt.org/8123
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic75adee4070b415b8855af1f2ea289825496fbc1
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list