Change in vdsm[master]: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.

abaron at redhat.com abaron at redhat.com
Mon Nov 5 21:46:31 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 480:         # At this point we successfully finished the 'copy' part of the operation
Line 481:         # and we can clear all recoveries.
Line 482:         vars.task.clearRecoveries()
Line 483:         # If it's 'move' operation, we should delete src image after copying
Line 484:         if op == MOVE_OP:
we should not fail if produce/delete fail here.
Line 485:             dom = sdCache.produce(srcSdUUID)
Line 486:             _deleteImage(dom, imgUUID, postZero)
Line 487: 
Line 488:         self.log.info("%s task on image %s was successfully finished", OP_TYPES[op], imgUUID)


--
To view, visit http://gerrit.ovirt.org/8507
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf01de7dc8bf0a903ebf94d9e33ffad9a195b7de
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list