Change in vdsm[master]: BZ#836161 - Rewrite of deleteImage().

ewarszaw at redhat.com ewarszaw at redhat.com
Mon Nov 5 21:41:06 UTC 2012


Eduardo has posted comments on this change.

Change subject: BZ#836161 - Rewrite of deleteImage().
......................................................................


Patch Set 12: (1 inline comment)

....................................................
File vdsm/storage/blockSD.py
Line 206:     try:
Line 207:         lvm.changelv(sdUUID, volUUIDs, (("-a", "y"), ("--deltag", imgUUID),
Line 208:                             ("--addtag", sd.REMOVED_IMAGE_PREFIX + imgUUID)))
Line 209:     except se.StorageException as e:
Line 210:         log.debug("SD %s, Image %s pre zeroing ops failed", sdUUID, imgUUID,
If the activation failed the zeroing will fail shortly anyway. If the retagging failed, anyway is worth to zeroing the volumes.
In the worst case a totally or partial blanked image will remain. Anyway the user wanted to removed it anyway.
Line 211:                     volUUIDs)
Line 212:     # Following call to changelv is separate since setting rw permission on an
Line 213:     # LV fails if the LV is already set to the same value, hence we would not
Line 214:     # be able to differentiate between a real failure of deltag/addtag and one


--
To view, visit http://gerrit.ovirt.org/8506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I304ff5cd70186ffc9789cd1ac9337efa6c5ff695
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list