Change in vdsm[master]: Add passwd command to vdsm-tool

lilei at linux.vnet.ibm.com lilei at linux.vnet.ibm.com
Mon May 28 07:48:06 UTC 2012


Lei Li has posted comments on this change.

Change subject: Add passwd command to vdsm-tool
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm.spec.in
Line 364
Hi Adam,

You are right. So the point is whether the vdsm-tool command should be called here.

If yes, will add line like "%{_bindir/vdsm-tool update-saslpasswd2}", but the question is does it make sense to call an vdsm-tool command here?  Then what's the meaning of moving these code into vdsm-tool module?

If no, have to set the password by run the vdsm-tool command manually, of course the previous package installation process would be changed.

Dan, Federico, Ryan, any ideas?

--
To view, visit http://gerrit.ovirt.org/4528
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lei Li <lilei at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list